Task #10756
[Internal Testing] wsSearchCompanyByIdOrName - companyId Filter Does not Work
Status: | Internal Testing | Start date: | April 27, 2020 | ||
---|---|---|---|---|---|
Priority: | Normal | Due date: | April 28, 2020 | ||
Assignee: | Rayvandy Gabbytian | % Done: | 90% | ||
Category: | - | Spent time: | - | ||
Target version: | - |
Description
Dear Chee Onn,
Can you check whether this one is existing production issue?
Reported Issue:
Any random word put inside companyId, the response will still return all companies.
Expected Results:
Since this is a search function, companyId should be able to filter by companyId or company name as per TSD. Kindly check for CIFNumber as well.
Request:
<soapenv:Envelope xmlns:soapenv="http://schemas.xmlsoap.org/soap/envelope/" xmlns:ws="http://ws.cas.penril.net"> <soapenv:Header/> <soapenv:Body> <ws:wsSearchCompanyByIdOrName> <ws:adminId>RCMS</ws:adminId> <ws:adminPassword>RCMSONL</ws:adminPassword> <ws:companyId>sudgfusydftuwer</ws:companyId> <ws:CIFNumber></ws:CIFNumber> <ws:provider>ID</ws:provider> <ws:pageNo>1</ws:pageNo> <ws:applicationId>200</ws:applicationId> </ws:wsSearchCompanyByIdOrName> </soapenv:Body> </soapenv:Envelope>
Response:
<soapenv:Envelope xmlns:soapenv="http://schemas.xmlsoap.org/soap/envelope/" xmlns:xsd="http://www.w3.org/2001/XMLSchema" xmlns:xsi="http://www.w3.org/2001/XMLSchema-instance"> <soapenv:Body> <wsSearchCompanyByIdOrNameResponse xmlns="http://ws.cas.penril.net"> <wsSearchCompanyByIdOrNameReturn> <![CDATA[ <?xml version="1.0" encoding="UTF-8" standalone="yes"?> <msg> <msgHeader> <responseCode>0</responseCode> <totalPage>0</totalPage> </msgHeader> <msgBody> <company> <companyID>IDKARYA</companyID> <companyName>KARYAWAJA EKAMULIA</companyName> <recordId>1513218657770</recordId> <provider>INDONESIA</provider> </company> <company> <companyID>IDOASE</companyID> <companyName>PT IINFORMATIC OASE</companyName> <recordId>1538723005874</recordId> <provider>INDONESIA</provider> </company> <company> <companyID>IDTVLK</companyID> <companyName>Traveloka Indonesia</companyName> <recordId>1544173558133</recordId> <provider>INDONESIA</provider> </company> <company> <companyID>IDALII0526</companyID> <companyName>ASURANSI ALLIANZ LIFE INDONESIA PT</companyName> <recordId>1558501350267</recordId> <provider>INDONESIA</provider> </company> <company> <companyID>IDIDGREENTEA</companyID> <companyName>Green Tea Corp.</companyName> <recordId>1558944110548</recordId> <provider>INDONESIA</provider> </company> <company> <companyID>IDGREENTEA</companyID> <companyName>Green Teah CV.</companyName> <recordId>1558944326544</recordId> <provider>INDONESIA</provider> </company> <company> <companyID>IDHARYONO</companyID> <companyName>HARYONO</companyName> <recordId>1379338331227</recordId> <provider>INDONESIA</provider> </company> <company> <companyID>IDGENIUSPC</companyID> <companyName>GENIUS PC PTD LTD</companyName> <recordId>1379588718953</recordId> <provider>INDONESIA</provider> </company> <company> <companyID>IDKOPKAR</companyID> <companyName>KOPKAR BII</companyName> <recordId>1380253541081</recordId> <provider>INDONESIA</provider> </company> <company> <companyID>IDUNEED</companyID> <companyName>UNEED INDONESIA</companyName> <recordId>1527126968080</recordId> <provider>INDONESIA</provider> </company> </msgBody> </msg> ]]> </wsSearchCompanyByIdOrNameReturn> </wsSearchCompanyByIdOrNameResponse> </soapenv:Body> </soapenv:Envelope>
History
#1 Updated by Ngoh Chee Onn over 4 years ago
- Status changed from New - Begin Life Cycle to Internal Testing
- Assignee changed from Ngoh Chee Onn to Rayvandy Gabbytian
- % Done changed from 0 to 90
Hi Gabby,
Please refer current code logic in below, because of the 'Or' condition in query, when CIF number empty and Company Id not empty, it will return all company.
Query Logic : UPPER LIKE CompanyId OR UPPER LIKE CIFNumber
Thank you