Task #11702
[Source Code Review] Trade Finance
| Status: | Closed - End of life cycle | Start date: | April 21, 2021 | |
|---|---|---|---|---|
| Priority: | Normal | Due date: | ||
| Assignee: |  Stephanie Sufrapto | % Done: | 100% | |
| Category: | - | Spent time: | - | |
| Target version: | - |
Description
Dear Stephanie,
Once Agrobank requested for migration package, don't forget to assign source code review to Chee Ping.
Thank you.
History
#1
Updated by Stephanie Sufrapto about 3 years ago
- Assignee changed from Stephanie Sufrapto to Ngoh Chee Ping
Hi Chee Ping,
Please help to code review project below
Branch: eTrade Finance
https://cloud.penril.my/hg/agrobank/agro_admin
https://cloud.penril.my/hg/agrobank/agro-bib/
https://cloud.penril.my/hg/agrobank/ibssCore/
https://cloud.penril.my/hg/agrobank/agro-esb/
https://cloud.penril.my/hg/commons/utils/
https://cloud.penril.my/hg/commons/report-generator/
#2
Updated by Ngoh Chee Ping about 3 years ago
- Status changed from New - Begin Life Cycle to Pending Fixes
- Assignee changed from Ngoh Chee Ping to Stephanie Sufrapto
Please find the code review finding as below, and apply the fixes.
IBAM
1) ibssCompanyUserMaintCreate.jsp
Contain 2 etradeFinance service Line 363-369 and line 421-427. Please remove the 1 that not used.
BIB
1) /ib166_etrade_finance/struts-config.xml
Line 24 - forward back not suppose back to .ib166.facilities.enquiry.main ? Now when click back will back to same page not back to previous page.
Line 30 - forward back not suppose back to .ib166.facilities.enquiry.lvl.0 ? Now when click back will back to same page not back to previous page.
2) IBEtradeFacilitiesLvl2Services
Line 57 - "unlikely-arg-type" if not used, please remove it.
3) IBEtradeTrxnHistoryDetailsServices
Line 64 - "unused", "unchecked" if not used, please remove it.
#3
Updated by Stephanie Sufrapto about 3 years ago
- Status changed from Pending Fixes to Code Review
- Assignee changed from Stephanie Sufrapto to Ngoh Chee Ping
- % Done changed from 0 to 100
IBAM (1) and BIB (1,3) done
For BIB i change my jsp seems i called the wrong action to call. Changes in 2jsp, 1 new action class and struts config.
Kindly check if there is any other issue
#4
Updated by Ngoh Chee Ping about 3 years ago
- Assignee changed from Ngoh Chee Ping to Stephanie Sufrapto
Done, no issues.
#5
Updated by Stephanie Sufrapto almost 3 years ago
- Status changed from Code Review to Closed - End of life cycle