Task #11705: [Source Code Review] DuitNOW QR - CR20006 - DuitNOW QR - Penril Support System

Task #11705

[Source Code Review] DuitNOW QR

Added by Rayvandy Gabbytian over 3 years ago. Updated almost 3 years ago.

Status:

Closed - End of life cycle

Start date:

April 21, 2021

Priority:

Normal

Due date:

Assignee:

Siti Balqis Othman

% Done:

100%

Category:

Spent time:

5.00 hours

Target version:

Description

Dear Stephanie,

Once Agrobank requested for migration package, don't forget to assign source code review to Chee Ping.

Thank you.

History

#1 Updated by Siti Balqis Othman over 3 years ago

Assignee changed from Siti Balqis Othman to Ngoh Chee Ping

Hi Chee ping,

Could you help to do a source code review for CR DuitNow RPP?

Branch Name: CR20006-QR Payment-JDK1.8
Project List:

Thank you.

#2 Updated by Ngoh Chee Ping over 3 years ago

Assignee changed from Ngoh Chee Ping to Siti Balqis Othman

Finished Code Review, please check below finding and help to fix it. TQ

1) TextFileServices class method createMerchantFileWriter only generate 1 merchant file, inside FtpUtils class uploadFileFTPClient method no need to have localFolder.listFiles. This will send all the files in the same folder even not merchant file also will send to paynet.

2) reporting project did not merge with CR20006-QR Payment branch, because did not found the QR_Merchant_Registration.jrxml and jasper file in CR20006-QR Payment-JDK branch

3)for those field commented but no use, can be remove in
agro-bib/WebContent/jsp/ib165_merchant_onboard/ibsMerchantOnboardEditConfirm.jsp
agro-bib/WebContent/jsp/ib165_merchant_onboard/ibsMerchantOnboardSharedConfirm.jsp
agro-bib/WebContent/jsp/ib165_merchant_onboard/ibsMerchantOnboardSharedResult.jsp

4) Remove sysout in
/agro_admin/src/com/ib/ibss/controller/actions/ss106_maker_checker/IBSSApprovalMainAction.java

5) Should check m_oMaster.getMkBy() != null before findById
Line 78 - /agro_admin/src/com/ib/ibss/enterprise/services/ss106_maker_checker/MakerCheckerSharedServices.java