Task #4765

R1 Source code review feedback

Added by Anonymous almost 10 years ago. Updated over 9 years ago.

Status:Closed - End of life cycleStart date:October 07, 2014
Priority:NormalDue date:October 09, 2014
Assignee:-% Done:

100%

Category:-Spent time:-
Target version:-

Description

Pls assist fix those issues. Those require Bank for confirmation, needed Bank feedback before we can proceed.

Source Code Review - Critical-Penril Feedback.xlsx (23.6 KB) Anonymous, October 07, 2014 14:59

Source_Code_Review_High - Penril_Feedback.xlsx (95 KB) Anonymous, October 07, 2014 14:59

History

#1 Updated by Ong Wei Kuan almost 10 years ago

  • Status changed from New - Begin Life Cycle to Finished Development
  • % Done changed from 0 to 100

Done Source code clean up.

-Removed some unused classes.
-Removed commented items from code and jsp.
-Removed sensitive data print out.
-Changed to use stringbuffer instead of string concatenation in some cases.
-Declared object outside the loop based on the design.
-Closed stream objects after use.

#2 Updated by Anonymous almost 10 years ago

  • Status changed from Finished Development to Pending SIT Deployment
  • Assignee changed from Ong Wei Kuan to Anonymous

#3 Updated by Anonymous almost 10 years ago

  • Status changed from Pending SIT Deployment to Work Completed-End life cycle

#4 Updated by Anonymous over 9 years ago

  • Status changed from Work Completed-End life cycle to Closed - End of life cycle

Also available in: Atom PDF