B - Production Support » BSN CDB Support

Salam Najmi,
please review my code. Thank you.

IBAM
Class: IBSSComUserDeleteServices

List<BibTransactionHistory> pendingVerifyList = getBibTransactionHistoryDAO().getAllPendingVerifyList(bibUser.getCompanyId());
if(bibUser.getRole().equals("5") && pendingVerifyList.size() > 0) {
throw IBSSErrorHandler.createBusinessException("delete.","authorize.error.exception");
}

List<BibTransactionHistory> pendingApprovalList = getBibTransactionHistoryDAO().getAllPendingApprovalList(bibUser.getCompanyId());
if(bibUser.getRole().equals("3") && pendingApprovalList.size() > 0) {
throw IBSSErrorHandler.createBusinessException("delete.","authorize.error.exception");
}

1. Use "5".equals(bibUser.getRole()) to avoid null exception. Same to "3".
2. Call getAllPendingVerifyList after role checking. No reason to get tnrx list if role is not related. Same for getAllPendingApprovalList

BSNeBiz
Class: IBUserManagementDeleteServices

1. Same as IBAM

Athira,
done deployment at sit environment. Kindly retest.

Finding: No validation to delete authorize user when there are still pending verify and pending approval
Solution: Add the validation to delete authorize user

Tested and passed.

22/03/21 - Tested and failed by Azyan.

Error prompt correctly. However user received email where user had been deleted. Action is made in IBAM and CDB

Hi Athira,
the issue has been fixed. Kindly retest.

Tested and passed.

Tested and Passed on SIT (15/4/2021)

Kindly deploy the fixes to UAT environment.

Thank you

UAT deployment has been done on 16/04/2021. Kindly proceed with user testing.

Tested and passed.

Kindly prepare for preprod deployment.

Thank you

Production deployed on 07/05/2021

Migration ID 0033