B - Production Support » BSN CDB Support

Please help to fix this issue.

Please help doing code review.
The condition that ensures the email is sent to valid checkers for Approval Application had been added.

Hi Wen Hong,

Your code fix is working but you only updated at 2 codes. There are 5 similar codes.
I recommend you to filter user status at getAdminUserProfileDAO().getUsersByStateCodeRole. By doing this, the fix is applied to all codes.
Please refer to attached screenshot.

Hi Najmi,

I completed the code that filters user status at getAdminUserProfileDAO().getUsersByStateCodeRole.
Please help doing code review.
Thanks.

Hi Wen Hong,

Your code fix works. But I recommend updating the Criteria. Please refer method 'public List<AdminUserProfile> getUsersGroup(long groupId)'
Referring to pic2.png, your code has 2 list cycles. If the result list has, for example 1,000,000 users, the second cycle will take time to complete because the code will compare each user status one by one.

Hi Najmi,

I completed updating it to Criteria method for filtering DELETED users.
Please help checking it.
Thanks.

Please ignore

Hi Wen Hong,

Please understand how to manipulate class Criteria. Do not copy paste without understanding the reference.

Fix as below:

getSession().beginTransaction();
Criteria crit = getSession().createCriteria(AdminUserProfile.class);
crit.add(Restrictions.eq("userState", stateCode));
crit.add(Restrictions.eq("userAdminRole", role));
Criteria userCrit = crit.createCriteria("mainProfile"); no reason to create new Criteria. mainProfile is for JOIN function
userCrit.add(Restrictions.ne("userState", USER_STATUS.DELETED.getValue()));
userList =userCrit.list();

TO

getSession().beginTransaction();
Criteria crit = getSession().createCriteria(AdminUserProfile.class);
crit.add(Restrictions.eq("userState", stateCode));
crit.add(Restrictions.eq("userAdminRole", role));
crit.add(Restrictions.ne("userState", USER_STATUS.DELETED.getValue()));
userList = crit.list();

Hi Najmi,

The Issue, Finding, Solution and Test steps are added.
Thanks.

Issue:
IBAM Checker has been deleted from IBAM User Manager but still received email for Approval Application.

Finding:
A condition needs to be added to filter DELETED users (including IBAM Maker and Checker) before processing email.

Solution:
In getAdminUserProfileDAO().getUsersByStateCodeRole method, restriction is added to filter DELETED users out of valid users.
-----
Criteria userCrit = crit.createCriteria("mainProfile");
userCrit.add(Restrictions.ne("userState", USER_STATUS.DELETED.getValue()));
-----

1. Maker: IBAM > CORPORATE BACK END > CDB Application
2. Create new application / Edit existing application
3. Press submit button at confirmation page
4. System will send email to valid Checkers for Approval and display page with "submitted and pending for approval" message.

1. Select an IBAM checker with testing email. For example, user AHMAD with State Kuala Lumpur
2. Access IBAM>BBE>Admin User Management>Delete user
3. Access IBAM > CORPORATE BACK END > CDB Application
4. Create new application / Edit existing application with State Kuala Lumpur
5. Press submit button at confirmation page
6. Expected result, IBAM will send email to valid Checkers for Approval and display page with "submitted and pending for approval" message. Deleted user will not receive an email.

SIT deployed on 18/03/2021

Hi Weng Hong,

After test, found that the deleted checker still receive one of the email "IBAM Pending Approval: Create Application Form".
Kindly recheck on this.

Hi Erni,

I found that line 215 (sendEmailtoChecker) might be the cause but I could not fix it as this is not from my branch, it might be issue from branch 'email to checker'.

Tested and passed at SIT

Tested and Passed on SIT (15/4/2021)

Kindly deploy the fixes to UAT environment.

Thank you

UAT deployed on 16/04/2021

Tested and passed by Mazni on 27/4/21

Please prepare for preprod deployment.

Production deployed on 07/05/2021

Migration ID0033