Task #11565

[SCP ID :##5775##] : Maker unable to edit Account Management

Added by Zahir Abd Latif over 3 years ago. Updated about 3 years ago.

Status:Work Completed-End life cycleStart date:April 28, 2021
Priority:NormalDue date:June 04, 2021
Assignee:Zahir Abd Latif% Done:

100%

Category:-Spent time:-
Target version:-

Description

Hi,
Kindly attend below request:-

UKB Maker unable to edit Account Management as system prompt 'Organization account is pending for approval'. But no approval list display in UKB Checker screen.
After set mk_pending_account = 0 in db, error still prompt

11565 - update acc managemnt.docx (3.68 MB) Nurul Athira Abdul Rahim, May 05, 2021 12:03

History

#1 Updated by Ngoh Chee Ping over 3 years ago

  • Assignee changed from Nurul Athira Abdul Rahim to Lai Wen Hong

Please help to fix this issue.

#2 Updated by Lai Wen Hong over 3 years ago

  • Assignee changed from Lai Wen Hong to Nurul Athira Abdul Rahim

Please check whether this issue is simulated by the steps listed in section A or by any other steps.

A. This issue is simulated with these steps below:
1. Maker stays in Account Management section.
2. ACCOUNT_MK_PENDING in BIB_COMPANY table is set from 1 to 0.
3. Maker continues editing in Account Management section.
4. Error "Organization account is pending for approval" is prompted.

B. There is no this issue with these steps below:
1. Maker stays in Account Management section.
2. ACCOUNT_MK_PENDING in BIB_COMPANY table is set from 1 to 0.
3. Maker refreshes Account Management section and then edits.
4. Error "Organization account is pending for approval" is not prompted.

#3 Updated by Nurul Athira Abdul Rahim over 3 years ago

  • Status changed from New - Begin Life Cycle to Development / Work In Progress
  • Assignee changed from Nurul Athira Abdul Rahim to Lai Wen Hong

Hi Wen Hong,

Confirmed by Azyan that they did like step no 2.

Azyan updated ACCOUNT_MK_PENDING and user refresh the screen but still system throw error as stated.

#4 Updated by Lai Wen Hong over 3 years ago

  • Assignee changed from Lai Wen Hong to Nurul Athira Abdul Rahim

The error "Organization account is pending for approval" still is not prompted in my testing after following the steps stated.
I asked Najmi about this and the possible cause is the db script when updating AccountMkPendingFlag is not committed properly.

#5 Updated by Nurul Athira Abdul Rahim over 3 years ago

  • Due date set to March 18, 2021
  • Assignee changed from Nurul Athira Abdul Rahim to Lai Wen Hong
  • Start date changed from March 03, 2021 to March 16, 2021

Hi Wen Hong, please help to find the root cause of the error.
If you need anything can directly contact Najmi or me.

Thank you

#7 Updated by Lai Wen Hong over 3 years ago

Findings:
(2021-03-18)
1. Enabled invalid digit account
- According to the screenshot received by Najmi from JTM, UKB Admin Maker enabled invalid digit account.
- During testing, Admin Maker is not allowed to enable invalid digit account.
- This issue had been reported to Azyan.

Could not find other case that causes "UKB Maker unable to edit Account Management as system prompt 'Organization account is pending for approval'. But no approval list display in UKB Checker screen." and "After set mk_pending_account = 0 in db, error still prompt".

#8 Updated by Lai Wen Hong over 3 years ago

  • % Done changed from 0 to 50

Findings:
(2021-03-22)
2. After set mk_pending_account = 0 in db, error still prompt
- The error prompted is "Service is currently unavailable." error.
- After the error was prompted, populateBibAccountList() function had stopped but mk_pending_account still turned to 1.
- Found that mk_pending_account is updated before processing populateBibAccountList() function.
- Solutions: mk_pending_account will be only updated after processing populateBibAccountList() function.

#Replicated an active invalid digit account and now fixing to enable Maker to disable invalid digit account.

#9 Updated by Lai Wen Hong over 3 years ago

  • % Done changed from 50 to 100

The updating of ACCOUNT_MK_PENDING in db is adjusted.
The addition of forcing user (Maker/Admin) to disable invalid digit account is finished.

Code is pushed.

#10 Updated by Lai Wen Hong over 3 years ago

  • Status changed from Development / Work In Progress to Code Review
  • Assignee changed from Lai Wen Hong to Najmi Pasarudin

#11 Updated by Najmi Pasarudin over 3 years ago

  • Assignee changed from Najmi Pasarudin to Lai Wen Hong
  • % Done changed from 100 to 90

Hi Wen Hong,
Code fix is good. Please merge to DEBUG branch.
Please write the test steps for the tester. In this case, developer need to prepare the invalid digit data to replicate the issue.
Once done, assign redmine to me for SIT deployment.

My Tips(optional):
  1. BSNAccount agroAccounts; <--- if minor changes, change to BSNAccount bsnAccount;
  2. if condition:

if(!codeA) runCodeB
else runCodeA

SAME AS

if(codeA) runCodeA
else runCodeB

#12 Updated by Lai Wen Hong over 3 years ago

  • Tracker changed from Support to Task
  • Status changed from Code Review to Pending SIT Deployment
  • Assignee changed from Lai Wen Hong to Najmi Pasarudin

Hi Najmi,

I modified code according to your tips.

  1. Need JTM help to get the invalid account
    Test Steps:
    1. Use IBAM Maker to login
    2. Access IBAM > CORPORATE BACK END > Organization Setup > Find Organization Name "Penril Datability" > Press Action "Edit" icon > Account Management
    2. Disactivate an active invalid digit account
    3. Press Next button to confirmation page
    4. Press Confirm button to result page
    5. Excepted result from Maker, will see "Accounts has been edited and pending for approval" message.

#13 Updated by Lai Wen Hong over 3 years ago

  • % Done changed from 90 to 0

Hi Najmi,

I modified code according to your tips.
Need JTM help to get the invalid account before start testing.

Test Steps:
  1. Use IBAM Maker to login
  2. Access IBAM > CORPORATE BACK END > Organization Setup > Find Organization Name "Penril Datability" > Press Action "Edit" icon > Account Management
  3. Disactivate an active invalid digit account
  4. Press Next button to confirmation page
  5. Press Confirm button to result page
  6. Excepted result from Maker, will see "Accounts has been edited and pending for approval" message

#14 Updated by Najmi Pasarudin over 3 years ago

  • Status changed from Pending SIT Deployment to Internal Testing
  • Assignee changed from Najmi Pasarudin to Nurul Athira Abdul Rahim
  • % Done changed from 0 to 90

SIT deployed on 31/03/2021.

#15 Updated by Nurul Athira Abdul Rahim over 3 years ago

  • Due date changed from March 18, 2021 to May 04, 2021
  • Status changed from Internal Testing to Development / Work In Progress
  • Assignee changed from Nurul Athira Abdul Rahim to Lai Wen Hong
  • Start date changed from March 16, 2021 to April 28, 2021
  • % Done changed from 90 to 70

Hi Wen Hong,

Tested and failed.

Role : Maker.

Azyan found "Error service currently unavailable prompt when click 'Submit'".

Kindly fix.

#16 Updated by Lai Wen Hong over 3 years ago

  • Status changed from Development / Work In Progress to Code Review
  • Assignee changed from Lai Wen Hong to Najmi Pasarudin

Hi Najmi,

Please help me in code review.

Thanks.

Finding:
  1. Condition is not strict enough on preventing invalid digit variable passing by wrong codes.
Solution:
  1. Added extra condition in checking to prevent invalid digit variable passing by wrong codes.

Test Steps:
(Use back the previous test steps.)

#17 Updated by Najmi Pasarudin over 3 years ago

  • Status changed from Code Review to Internal Testing
  • Assignee changed from Najmi Pasarudin to Nurul Athira Abdul Rahim
  • % Done changed from 70 to 90

SIT and UAT deployed on 04/05/2021

#18 Updated by Nurul Athira Abdul Rahim over 3 years ago

Tested and passed internally.

#19 Updated by Nurul Athira Abdul Rahim over 3 years ago

  • Status changed from System Integration Test to Pending UAT Deployment
  • Assignee changed from Nurul Athira Abdul Rahim to Najmi Pasarudin

Tested and passed by Azyan on 31/5/21

Kindly prepare to UAT deployment

#20 Updated by Najmi Pasarudin over 3 years ago

  • Status changed from Pending UAT Deployment to User Acceptance Test
  • Assignee changed from Najmi Pasarudin to Nurul Athira Abdul Rahim

UAT deployed on 02/06/2021

#21 Updated by Nurul Athira Abdul Rahim over 3 years ago

  • Due date changed from May 04, 2021 to June 04, 2021
  • Status changed from User Acceptance Test to Pending Prod Deployment
  • Assignee changed from Nurul Athira Abdul Rahim to Najmi Pasarudin

Tested and passed on UAT env.

Kindly prepare for pre-prod deployment.

#22 Updated by Najmi Pasarudin over 3 years ago

  • Status changed from Pending Prod Deployment to Pending Review
  • Assignee changed from Najmi Pasarudin to Nurul Athira Abdul Rahim
  • % Done changed from 90 to 100

Production deployed on 04/06/2021

#23 Updated by Nurul Athira Abdul Rahim about 3 years ago

  • Status changed from Pending Review to Work Completed-End life cycle
  • Assignee changed from Nurul Athira Abdul Rahim to Zahir Abd Latif

Migration ID0034

Also available in: Atom PDF